Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: create a new registry instead of reusing the static default registry in monitoring tests #11511

Merged
merged 1 commit into from
Aug 29, 2023
Merged

test: create a new registry instead of reusing the static default registry in monitoring tests #11511

merged 1 commit into from
Aug 29, 2023

Conversation

kruskall
Copy link
Member

Motivation/summary

TestDefaultMonitoringMapForRegistry and TestMonitoringMapForRegistry fails when running the tests multiple times

Checklist

- [ ] Update CHANGELOG.asciidoc
- [ ] Update package changelog.yml (only if changes to apmpackage have been made)
- [ ] Documentation has been updated

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

  • go test -run=TestMonitoring -race -count=100 -failfast ./...
  • go test -run=TestDefaultMonitoringMapForRegistry -race -count=100 -failfast ./...

Related issues

Closes #11172
Closes #11171

@kruskall kruskall requested a review from a team as a code owner August 28, 2023 18:19
@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2023

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Aug 28, 2023
@kruskall kruskall merged commit dca85ac into elastic:main Aug 29, 2023
7 checks passed
@kruskall kruskall deleted the test/fix-flaky-monitoring-test branch August 29, 2023 07:23
bmorelli25 pushed a commit to bmorelli25/apm-server that referenced this pull request Sep 5, 2023
@kruskall @bmorelli25
test: create a new registry instead of reusing the static default reg…
d4cb50b 
…istry in monitoring tests (elastic#11511)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axw axw axw approved these changes

@lahsivjar lahsivjar lahsivjar approved these changes

Assignees
No one assigned
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestMonitoringMapForRegistry flaky on rerun TestDefaultMonitoringMapForRegistry is flaky on rerun
3 participants
@kruskall @axw @lahsivjar